Replacing deprecated 'warn' function with 'warning' #3984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @bskjois , thank you for introducing this enhancement! Before we are going to merge the PR, would you mind to fix the style issues caught by the static checks? thanks in advance! |
Signed-off-by: Kowshik Jois B S <[email protected]> The warn() is deprecated in all the supported versions of python and is now removed in python3.13. Hence we should be using warning() which is functionally identical to warn(). Referrence: https://docs.python.org/3.12/library/logging.html#logging.Logger.warning https://docs.python.org/3.13/whatsnew/3.13.html#logging
bskjois
force-pushed
the
warnTOwarning
branch
from
aec14b4
to
3d7c375
Compare
|
Hello @luckyh, Thank you! |
luckyh
approved these changes
Sep 3, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The warn() is deprecated in all the supported versions of python and is now removed in python3.13.
Hence we should be using warning() which is functionally identical to warn().
Referrence:
https://docs.python.org/3.12/library/logging.html#logging.Logger.warning https://docs.python.org/3.13/whatsnew/3.13.html#logging